-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][experimental] Raise an exception if a DAG is compiled twice #47431
[core][experimental] Raise an exception if a DAG is compiled twice #47431
Conversation
Can you elaborate a bit on the original issue (why calling compile twice is a problem)? Checked #47398 but seems no further details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. nit comments on err msg update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
premerge failures |
weird, I think the RLlib CI failure is unrelated to this PR. Let me rebase with the master branch. |
Why are these changes needed?
If a DAG calls
experimental_compile
twice, the first compiled node may become a leaf node. For example,This PR raises an exception if a DAG is compiled twice.
Related issue number
Closes #47408
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.